Skip to content

add image size tag in image option header #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master-mysterious-egg-next
Choose a base branch
from

Conversation

emge-odoo
Copy link

@emge-odoo emge-odoo commented May 21, 2025

[DIVY] Image size is not being displayed in mysterious egg https://tinyurl.com/ym938ekk

@robodoo
Copy link

robodoo commented May 21, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg-next, it needs to be retargeted before it can be merged.

@emge-odoo emge-odoo force-pushed the master-mysterious-egg-emge-5 branch 3 times, most recently from 0b3987b to 6ffce16 Compare May 21, 2025 11:07
@ged-odoo ged-odoo force-pushed the master-mysterious-egg-next branch from 6e36b56 to 48edd7d Compare May 22, 2025 07:31
@emge-odoo emge-odoo force-pushed the master-mysterious-egg-emge-5 branch from 6ffce16 to 05d9be4 Compare May 22, 2025 08:49
@divy-odoo
Copy link

Thanks for the fix @emge-odoo! AFAIK, the fix won't work if the user changes the image quality or file format — it won't reflect the correct image size on the fly (reason: willStart) 🙂. Hope you are considering this case.

@emge-odoo emge-odoo force-pushed the master-mysterious-egg-emge-5 branch 2 times, most recently from 7cbe82d to e7d9c9b Compare May 22, 2025 14:58
@emge-odoo
Copy link
Author

Thanks for the fix @emge-odoo! AFAIK, the fix won't work if the user changes the image quality or file format — it won't reflect the correct image size on the fly (reason: willStart) 🙂. Hope you are considering this case.

Thanks for the feedback, you are right ! This should be fixed now.

@emge-odoo emge-odoo force-pushed the master-mysterious-egg-emge-5 branch 2 times, most recently from 9f66e62 to 29abf4d Compare May 22, 2025 14:59
@emge-odoo emge-odoo force-pushed the master-mysterious-egg-emge-5 branch from 29abf4d to 5697107 Compare May 23, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants